Skip to content

Commit

Permalink
Finish iwyu
Browse files Browse the repository at this point in the history
  • Loading branch information
reiniscirpons committed Dec 2, 2024
1 parent b868722 commit d5d0382
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 17 deletions.
23 changes: 12 additions & 11 deletions include/libsemigroups/sims.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
// TODO(0):
// * review the function aliases, and remove them if they are unnecessary
// * doc
// * iwyu
// * const
// * noexcept
// * nodiscard
Expand Down Expand Up @@ -72,11 +71,11 @@
#include <utility> // for move, pair, swap
#include <vector> // for vector

#include "constants.hpp" // for operator!=, operator==, Max, UNDEFINED
#include "debug.hpp" // for LIBSEMIGROUPS_ASSERT
#include "dot.hpp" // for Dot
#include "exception.hpp" // for LIBSEMIGROUPS_EXCEPTION, LibsemigroupsExcep...
#include "forest.hpp" // for Forest
#include "constants.hpp" // for operator!=, operator==, Max, UNDEFINED
#include "debug.hpp" // for LIBSEMIGROUPS_ASSERT
#include "dot.hpp" // for Dot
#include "exception.hpp" // for LIBSEMIGROUPS_EXCEPTION
#include "forest.hpp" // for Forest
#include "knuth-bendix.hpp" // for KnuthBendix, to_presentation
#include "matrix.hpp" // for DynamicMatrix, MatrixCommon, BMat
#include "presentation.hpp" // for Presentation, longest_rule_length, short...
Expand All @@ -85,10 +84,13 @@
#include "types.hpp" // for word_type, relation_type, congruence_kind
#include "word-graph.hpp" // for Joiner, WordGraph

#include "detail/felsch-graph.hpp" // for FelschGraph
#include "detail/fmt.hpp" // for format, print
#include "detail/iterator.hpp" // for detail/default_postfix_increment
#include "detail/rewriters.hpp" // for RewriteTrie
#include "detail/felsch-graph.hpp" // for FelschGraph
#include "detail/fmt.hpp" // for format, print
#include "detail/iterator.hpp" // for detail/default_postfix_increment
#include "detail/path-iterators.hpp" // for const_pstilo_iterator
#include "detail/report.hpp" // for ReportCell
#include "detail/rewriters.hpp" // for RewriteTrie
#include "detail/word-graph-with-sources.hpp" // for WordGraphWithSources

#include "rx/ranges.hpp" // for operator|, iterator_range

Expand Down Expand Up @@ -365,7 +367,6 @@ namespace libsemigroups {
//!
//! \exception
//! \no_libsemigroups_except
// TODO(0) (tests)
Subclass& init();

//! Copy constructor.
Expand Down
1 change: 1 addition & 0 deletions src/sims.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include "libsemigroups/froidure-pin.hpp" // for FroidurePin
#include "libsemigroups/knuth-bendix.hpp" // for KnuthBendix, to_present...
#include "libsemigroups/presentation.hpp" // for Presentation
#include "libsemigroups/ranges.hpp" // for shortlex_compare
#include "libsemigroups/runner.hpp" // for delta, Reporter
#include "libsemigroups/to-froidure-pin.hpp" // for to_word_graph
#include "libsemigroups/transf.hpp" // for Transf, one
Expand Down
17 changes: 11 additions & 6 deletions tests/test-sims.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,24 @@
#include "libsemigroups/matrix.hpp" // for DynamicMatrix, BMat
#include "libsemigroups/order.hpp" // for shortlex_compare, Order
#include "libsemigroups/presentation.hpp" // for Presentation
#include "libsemigroups/ranges.hpp" // for shortlex_compare
#include "libsemigroups/sims.hpp" // for Sims1
#include "libsemigroups/to-froidure-pin.hpp" // for make
#include "libsemigroups/to-presentation.hpp" // for to_presentation
#include "libsemigroups/transf.hpp" // for Transf
#include "libsemigroups/types.hpp" // for word_type
#include "libsemigroups/word-graph.hpp" // for WordGraph
#include "libsemigroups/words.hpp" // for operator""_w, operator+
#include <libsemigroups/constants.hpp> // for UNDEFINED
#include <libsemigroups/todd-coxeter.hpp> // for ToddCoxeter

#include "libsemigroups/detail/eigen.hpp" // for DenseBase::row
#include "libsemigroups/detail/fmt.hpp" // for format, print
#include "libsemigroups/detail/iterator.hpp" // for operator+
#include "libsemigroups/detail/report.hpp" // for ReportGuard, SuppressReportFor
#include "libsemigroups/detail/eigen.hpp" // for DenseBase::row
#include "libsemigroups/detail/felsch-graph.hpp" // for FelschGraph
#include "libsemigroups/detail/fmt.hpp" // for format, print
#include "libsemigroups/detail/iterator.hpp" // for operator+
#include "libsemigroups/detail/path-iterators.hpp" // for const_pstilo_iterator
#include "libsemigroups/detail/report.hpp" // for ReportGuard
#include "libsemigroups/detail/word-graph-with-sources.hpp" // for WordGra...

#include "rx/ranges.hpp" // for operator|, iterator_range

Expand All @@ -90,7 +95,7 @@ namespace libsemigroups {
using fpsemigroup::zero_rook_monoid;

namespace {
// TODO check_exclude
// TODO(2) check_exclude
template <typename P>
void check_include(P const& p, std::vector<word_type> const& e, size_t n) {
auto foo = [&e](auto const& wg) {
Expand Down Expand Up @@ -1195,7 +1200,7 @@ namespace libsemigroups {
{{4, 8}, {4, 5, 7}, {4, 7}, {5, 4, 7}};
Sims1 sims;
sims.presentation(p);
// TODO use SimsRefinerFaithful instead
// TODO(2) use SimsRefinerFaithful instead
for (auto it = forbid.cbegin(); it != forbid.cend(); it += 2) {
sims.exclude(*it, *(it + 1));
}
Expand Down

0 comments on commit d5d0382

Please sign in to comment.