make template cache thread-safe: metanorma/iso-10303#380

relaton · Oct 20, 2024 · 32cb88c · 32cb88c
1 parent e6b0fb8
commit 32cb88c
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/lib/relaton/render/template/template.rb b/lib/relaton/render/template/template.rb
@@ -8,8 +8,11 @@ module Template
       class CacheManager
         include Singleton
 
+        attr_accessor :mutex
+
         def initialize
           @cache = {}
+          @mutex = Mutex.new
         end
 
         def store(key, value)
@@ -74,9 +77,14 @@ def punct_field?(name)
 
         def template_process(template)
           template.is_a?(String) or return template
-          t = @templatecache.retrieve(template) and return t
-          t = ::Liquid::Template.parse(add_field_delim_to_template(template))
-          @templatecache.store(template, t)
+          t = nil
+          @templatecache.mutex.synchronize do
+            unless t = @templatecache.retrieve(template)
+              t = ::Liquid::Template
+                .parse(add_field_delim_to_template(template))
+              @templatecache.store(template, t)
+            end
+          end
           t
         end