fix: Integrate VeraId in account creation process #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodiakhq bot
pushed a commit
to relaycorp/veraid-jvm
that referenced
this pull request
Sep 18, 2023
So we can use it in relaycorp/letro-android#43
# Conflicts: # app/build.gradle # app/schemas/tech.relaycorp.letro.storage.LetroDatabase/1.json
# Conflicts: # app/src/main/java/tech/relaycorp/letro/contacts/ui/ManageContactScreen.kt
gnarea
changed the title
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
migulyaev
reviewed
Sep 25, 2023
app/src/main/java/tech/relaycorp/letro/onboarding/registration/RegistrationDomainProvider.kt
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/letro/onboarding/registration/RegistrationDomainProvider.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/letro/account/storage/AccountRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/letro/account/storage/AccountRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/letro/onboarding/registration/AccountCreationProcessor.kt
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/letro/server/messages/AccountRequest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/letro/account/model/Account.kt
Outdated
Show resolved
Hide resolved
|
Thanks for the review @mgulyaev10! Over to you. |
migulyaev
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LTR-60
High-level changes
server_connection_params.derfile).[email protected]), we now request a user name (e.g.,alice) in the current locale (e.g.,en_GB) -- the user may be running a (very) old version of the Letro app, which may not reflect the latest set of domain names supported by Relaycorp's Letro server.AwalaMessageParserimplementation for account creation messages, as they seemed unnecessary.Changes to ignore
I'd recommend ignoring the following packages during review:
tech.relaycorp.letro.server.messages: ASN.1 DER serialisation of Letro server messages, such as account creation; the final version of the contact pairing serialisers will be moved there.tech.relaycorp.letro.utils: Various Letro-agnostic utilities related to ASN.1, cryptography, etc.