Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Design review fixes #52

Merged
merged 4 commits into from
Sep 18, 2023
Merged

fix: Design review fixes #52

merged 4 commits into from
Sep 18, 2023

Conversation

migulyaev
Copy link
Contributor

@migulyaev migulyaev added the automerge Allow kodiak to automerge commit when all checks pass label Sep 18, 2023
@kodiakhq kodiakhq bot merged commit da8e89c into main Sep 18, 2023
@kodiakhq kodiakhq bot deleted the design_review_fixes branch September 18, 2023 17:05
maribelferreira
maribelferreira reviewed Sep 20, 2023
View reviewed changes
app/src/main/java/tech/relaycorp/letro/ui/theme/Type.kt
fontSize = 24.sp,
lineHeight = 32.sp,
letterSpacing = (-0.6).sp,
fontSize = 22.sp,
Copy link

@maribelferreira maribelferreira Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please change it to:

fontSize = 24.sp,
lineHeight = 30.sp,
letterSpacing = (-0.25).sp,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribelferreira maribelferreira maribelferreira left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
automerge Allow kodiak to automerge commit when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@migulyaev @maribelferreira