fix: Reflect WiFi hotspot availability on Android 13 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much @LilianaFaustinoBloco! All looks good to me. Q: Isn't "Observe the hotspot state only when the app is in foreground" already implemented in this version? |
|
Not yet, we are polling regardless of app state (background or foreground). But I'm working on it! |
LilianaFaustinoDev
force-pushed
the
hotspot-state-checker
branch
from
93d0403 to
8fe0a4b
Compare
|
@gnarea I think it's all! |
Filmaluco
approved these changes
Oct 4, 2022
gnarea
changed the title
gnarea
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
LGTM @LilianaFaustinoBloco! Thanks!
BTW, I just removed the Fixes #569 because we still want a long-term solution for that issue.
Speaking of which, can you please add a comment to #569 and briefly explain what's wrong with the current approach? That'd help me with the prioritisation process.
|
🎉 This PR is included in version 1.4.35 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes the hotspot state detection on Android 13.
What is the current behavior?
This is a temporary fix for #569 but a long-term solution is still needed.
What is the new behavior (if this is a feature change)?
On Android 13, we are looking to the gateway addresses request results to infer if hotspot is available.
In previous versions of Android, there is no behavior change.