Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to python 3.13 #278

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Update to python 3.13 #278

merged 2 commits into from
Jan 24, 2025

Conversation

ralphbean
Copy link
Member

No description provided.

@ralphbean ralphbean requested a review from Zyzyx as a code owner January 24, 2025 14:12
webbnh
webbnh approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I have a couple of questions.

Do you really want to replace 3.12 with 3.13, or should we be adding 3.13 and keeping 3.12? On a related note, why drop 3.12 and not also drop 3.9? (I.e., what is the requirement that we're meeting, here?)

@ralphbean
Copy link
Member Author

Yeah, I had a similar thought (to just drop 3.9). Our only real use is in our deployment and I think that's on 3.13.

@ralphbean ralphbean enabled auto-merge (squash) January 24, 2025 19:49
@ralphbean
Copy link
Member Author

/retest sync2jira-sync-page-on-pull-request

@ralphbean ralphbean disabled auto-merge January 24, 2025 20:19
@ralphbean ralphbean merged commit 723c765 into main Jan 24, 2025
5 checks passed
@ralphbean ralphbean deleted the py313 branch January 24, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@Zyzyx Zyzyx Awaiting requested review from Zyzyx Zyzyx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphbean @webbnh