Depend on python3-legacy-cgi for F41+ #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix release-engineering#64 The Python `cgi` module is deprecated since Python 3.11 and removed from the standard library since Python 3.13. According to PEP 594 https://peps.python.org/pep-0594/#cgi there is no drop-in replacement for `cgi.FieldStorage`. Since we use it for POST requests, I spent a couple of hours trying to reimplement our code using python3-multipart but I am not getting closer to a working solution. Let's not pay the technical debt yet and depend `python3-legacy-cgi` for as long as we can.
xsuchy
approved these changes
Sep 11, 2024
|
This is breaking the CI. Merging early. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64
The Python
cgimodule is deprecated since Python 3.11 and removed from the standard library since Python 3.13. According to PEP 594 https://peps.python.org/pep-0594/#cgithere is no drop-in replacement for
cgi.FieldStorage. Since we use it for POST requests, I spent a couple of hours trying to reimplement our code using python3-multipart but I am not getting closer to a working solution.Let's not pay the technical debt yet and depend
python3-legacy-cgifor as long as we can.