-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use install-action to speed up installation of cargo tools #146
Conversation
Testing - https://github.com/joshka/tui-big-text/actions/runs/9276630769/job/25524107004
|
action.yml
Outdated
# TODO fix this | ||
description: "Release-plz version to use. It must be an existing git tag name. For example `release-plz-v0.2.45`. (Default: `latest`)." | ||
default: "release-plz-v0.3.70" | ||
default: "0.3.70" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is already a bit weird. You're making a release tool, for releasing crate versions, then publishing that tool to crates.io, but then installing it from your git repo via a specific tag version...
I suppose this makes sense if you're wanting to test out new versions of the tool in an action against a not yet released version of release-plz. I'm not sure if binstall supports some sort of git-tag version specifier.
I suspect this might break some small amount of workflows that specify this, but maybe the logic below can detect this and chop out the release-plz-v prefix somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then installing it from your git repo via a specific tag version
yes, this is because I was using an action that wasn't integrated with crates.io.
I suspect this might break some small amount of workflows
I'm not aware of any. This new approach should work well :)
For testing, typically I use cargo install
because I don't tag "dev" versions in release-plz repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this might break some small amount of workflows that specify this,
Now that I think about it. Yes, I think I broke some people GitHub actions. This should have been a 0.6.0 D:
The updater script is broken now. But I would like to experiment with a new "release" approach. |
This reverts commit 617abcd. The faster approach is now part of the main release-plz action. Fixed in: release-plz/action#146
Tested in https://github.com/joshka/tui-big-text/actions/runs/9325690976/job/25673100085 |
Fixes: #145