fix: support token with space like Bearer xxxxx

[davidB]

I guess, having the input token set with space like Bearer xxxx, is the cause of an error like

-- Running release-plz release --
error: unexpected argument '***' found

Usage: release-plz release [OPTIONS]

For more information, try '--help'.

(the *** is the output, hidden by github workflow because comes from a secret)

[marcoieni]

The test is failing. Did you test your branch and check that this fixed your issue?

[marcoieni]

improved the error message here: release-plz/release-plz#1682

[davidB]

No, the workflow were not activated on my fork.
I'll fix it.

[marcoieni]

ok, please also test your action directly against your project to check if this fix solves your issue.

[marcoieni]

is this trick used to work with whitespace? If yes, why are we using it also in the backend, which is one world only?
Same for ALT_REGISTRY probably

[davidBernardWefox]

yes this trick is to keep the separation of argument clean as defined in the array. I also apply it BACKEND and ALT_REGISTRY for:

• consistency (same pattern for every arguments fragment)
• to guide if new argument should be added in the future (no question about which "form" to use)

[marcoieni]

doesn't TOKEN="--token \"${{ inputs.token }}\"" work?
I.e. adding " around the token

[davidB]

doesn't TOKEN="--token \"${{ inputs.token }}\"" work? I.e. adding " around the token

No I tried it, same issue than with my first try with single quote, the double quote is included into the arguments when combined with $(...) or eval.

To test the various approach locally I used a small script to display every args.

#!/bin/bash 
for i in "$@"; do 
  echo "$i" 
done

bash-5.2$ V2="hello \"foo bar\""
bash-5.2$ ./my_cmd.sh ${V2}
hello
"foo
bar"

I remembered the tricks about array, but was not sure about the syntax, so quick search on SO: https://superuser.com/questions/360966/how-do-i-use-a-bash-variable-string-containing-quotes-in-a-command

[davidB]

FYI, the github workflow aren't triggered on my fork (I enable them, but no trigger).
But I just test it on one of my project with success. (that also confirms the fixed about HTTP 1.1 and the SSL issue I got on github-runner)

[marcoieni]

Ok so this trick allows to use " inside an argument.
Why do you need "? Does your token contain this character?

[marcoieni]

Also, "Bearer" is already set by release-plz:

https://github.com/MarcoIeni/release-plz/blob/e4cc526d9ee11e18c6319d72529fcb07ddebc352/crates/release_plz_core/src/git/github_client.rs#L40

[davidB]

Ok so this trick allows to use " inside an argument.
Why do you need "? Does your token contain this character?

No, this trick allows to NOT have ". Using array allows to have args has expected:

# what we what (without variable)
bash-5.2$ ./my_cmd.sh "hello" "foo bar"
hello
foo bar

# if we just quote (single or double) inside the variable
bash-5.2$ V2="hello \"foo bar\""
bash-5.2$ ./my_cmd.sh ${V2}
hello
"foo
bar"
bash-5.2$ ./my_cmd.sh "${V2}"
hello "foo bar"

# solution with array
V1=("hello" "foo bar")
bash-5.2$ ./my_cmd.sh $V1
hello
bash-5.2$ ./my_cmd.sh $V1[@]
hello[@]
bash-5.2$ ./my_cmd.sh ${V1[@]}
hello
foo
bar
# hourra !!
bash-5.2$ ./my_cmd.sh "${V1[@]}"
hello
foo bar

# with empty array
bash-5.2$ V3=()
bash-5.2$ ./my_cmd.sh "${V3[@]}"
bash-5.2$ 

[davidB]

Also, "Bearer" is already set by release-plz:

https://github.com/MarcoIeni/release-plz/blob/e4cc526d9ee11e18c6319d72529fcb07ddebc352/crates/release_plz_core/src/git/github_client.rs#L40

I don't need "Bearer" for github token, but for crates registry's token

[marcoieni]

I'm this close to rewrite this bash script in typescript 😂
Thanks!

[marcoieni]

released 👍