Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically post on facebook page #30

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

sahanh
Copy link

@sahanh sahanh commented May 28, 2017

I am proposing a feature to post needs on a facebook page automatically. I've implemented the initial code and submitting with the pull request. I've created a test page with a test app to test out the feature,

https://www.facebook.com/SL-Flood-Relief-137605090120516/

A long lived access token needs to be saved in .env . I can shared the fb credentials I am using over a private message. But would be ideal if a page with traction is linked @danishka

Hope it will become helpful

@gayanhewa
Copy link
Contributor

The code looks alright, please rebase your branch seems to be outdated from the master. If possible add an image on how it actually looks GIF may be?

@sahanh
Copy link
Author

sahanh commented May 29, 2017

This is how the post looks, the need creation flow remains the same without any changes. I've rebased the changes. How should we go about adding the page tokens?

@gayanhewa
Copy link
Contributor

gayanhewa commented May 29, 2017

You can use the app tokens and we can add it to the .env template. Sample test keys can be committed to .env.sample but actual production app keys need to be handled with someone managing the deployments. Looks good, thanks for this 👍

Copy link
Contributor

@gayanhewa gayanhewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once rebased we should be good to go with this. But we will have to coordinate the secrets for the production facebook app and also update the .env.sample for any dev / staging env keys

@chamilad
Copy link
Contributor

Would posting the number of the requester be a potential violation of privacy? Should it be a concern at this point or should we just focus on connecting the two parties?

@danishka
Copy link
Collaborator

@sahanh appreciate if you can pic a high priority task available.
https://github.com/reliefsupports/reliefsupports.org/wiki/Priority-Tasks-2017-05-31
Please do check if someone already working on a ticket before selecting.

sahanh added 10 commits May 31, 2017 11:40
updated addNeed to return created need for later access
…to feature/fb_integration

* 'feature/fb_integration' of github.com:sahanh/web-app:
  updated sample env
  implemented fb notification system
  returning fb post id
  implemented need update
  added fb_post_id to fillables
  migration to add fb_post_id to db
  added fb sdk
  opt-in into an exception based flow in repository updated addNeed to return created need for later access

# Conflicts:
#	.env.example
#	app/Http/Controllers/NeedsController.php
#	app/Need.php
@sahanh
Copy link
Author

sahanh commented May 31, 2017

@gayanhewa Gayan, I've rebased the changes and updated .env.example with my test credentials. The sample page it's linking to is https://www.facebook.com/SL-Flood-Relief-137605090120516/
Also updated the readme to cover the steps to generate the page token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants