need person's location add using google maps #48

dulajsan · 2017-05-28T21:49:29Z

Add GPS location when someone submit their needs. It is optional.

gayanhewa · 2017-05-29T05:12:15Z

flood_2017-05-29.sql

+-- Table structure for table `donations`
+--
+
+CREATE TABLE `donations` (


You need to add a migration use artisan cli tool , otherwise its going to be diffcult to manage the DB upgrades / changes

gayanhewa

Once the migrations are added we should be good to go with this PR

chamilad · 2017-05-29T18:03:01Z

app/Need.php

@@ -12,6 +12,6 @@ class Need extends Model
     * @var array
     */
    protected $fillable = [
-        'name', 'telephone', 'address', 'city', 'needs', 'heads'
+        'name', 'telephone', 'address','latlon', 'city', 'needs', 'heads'


IMO latlon is a bit unreadable at first sight. Maybe something like geolocation?

okay i will change

chamilad · 2017-05-29T18:05:33Z

resources/views/frontend/needs/add.blade.php

+                        </div>
+
+
+


Too many blank lines.

chamilad · 2017-05-29T18:06:20Z

resources/views/frontend/needs/add.blade.php

+                              <button type="button" onclick="getLocation()" class="btn btn-primary">සිතියමට ඇතුල් කරන්න</button>
+                            <p id="demo">&nbsp;</p>
+                                <div id="mapholder" style="width:55%;height:300px">
+                                </div>


Can we use the Maps API to get the general area from the address input above?

https://developers.google.com/maps/documentation/geocoding/intro

yes we can. but if some one enter a wrong address, it will be a problem

Yes. It could be more work at the moment, but can something like the following be done?

User enters an address

An attempt is made to obtain the geolocation using that address.

If the locations are received, the map is refreshed to show that location.

If the location is wrong on the map, the user adjusts it.

Maybe this can be an improvement after these current changes are merged.

That will be fine. i will work on it.

there is an issue to add MAP API

Yes. Looks like there are several issues with different scopes on Maps. @danishka does this cover what you had in mind for #50 ?

Also #6 also seems to be similar in scope to this.

chamilad

Please investigate the possibility of getting the geocode from the address itself.

dulajsan · 2017-05-30T07:20:43Z

updated to getting geocode from address. please review it and notify me

chamilad · 2017-05-30T07:36:36Z

resources/views/frontend/needs/add.blade.php

+            function showError(error) {
+            switch(error) {
+                case "ZERO_RESULTS":
+                    x.innerHTML = "ඔබගේ ලිපිනය සොයාගත නොහැක . රතු පැහැති  සලකුණ ඇදගෙන යාමෙන්  ඔබ සිටින ස්ථානය ලකුණු කල හැක "


Would these have to be i18nized? Not sure if that PR was merged.

these are the defined errors of the geocode. i checked those errors and printed customized errors messages for these defined errors

@chamilad Do we have i18n support at the moment? Does resources/lang contain them?

Edit : Seems https://github.com/reliefsupports/reliefsupports.org/pull/122 gives i18n support.

chamilad · 2017-05-30T07:38:07Z

@dulajsan Please include a screenshot of the UI if possible. Thanks for implementing this! I think this will also make a good starting point for a broader map feature.

dulajsan · 2017-05-30T08:02:03Z

danishka · 2017-05-31T03:37:03Z

@dulajsan appreciate if you can fix conflict and test once with latest code in your local.

danishka · 2017-06-05T15:12:09Z

@thinkholic is this already in production?
I did not noticed it yet.

gayanhewa · 2017-06-05T15:44:52Z

resources/views/frontend/needs/add.blade.php

+            }
+        }
+
+        </script>


@dulajsan please get an update from dev and add the translations for these

gayanhewa · 2017-06-05T15:46:28Z

app/Providers/AppServiceProvider.php

@@ -13,7 +14,8 @@ class AppServiceProvider extends ServiceProvider
     */
    public function boot()
    {
-        //
+        Schema::defaultStringLength(191);


This is fine for now, this is due to the multi-byte utf support that's needed. But we need to find a mechanism to go around the default string length problem and move this concert someplace that makes sense.

Geolocation integration forked from PR #48

dulajsan · 2017-06-08T02:51:48Z

resources/views/frontend/needs/add.blade.php

@@ -137,19 +138,19 @@ function showPosition(position) {
            function showError(error) {
            switch(error) {
                case "ZERO_RESULTS":
-                    x.innerHTML = "ඔබගේ ලිපිනය සොයාගත නොහැක . රතු පැහැති  සලකුණ ඇදගෙන යාමෙන්  ඔබ සිටින ස්ථානය ලකුණු කල හැක "


added i18n support. Now we can expose requester location.

dulajsan · 2017-06-08T02:58:59Z

danishka · 2017-06-14T20:47:24Z

@dulajsan I have tested in staging and its not convenient as we search in Google maps.
Is it possible to type and search for a location?

dulajsan · 2017-06-15T04:47:59Z

@danishka yes we can type in address field. Then the map will focused to relevant address. ex: If we type nugegoda, the map will focused to nugegoda

need person location add using google maps

2074fdb

dulajsan closed this May 28, 2017

dulajsan reopened this May 28, 2017

gayanhewa reviewed May 29, 2017

View reviewed changes

gayanhewa suggested changes May 29, 2017

View reviewed changes

chamilad reviewed May 29, 2017

View reviewed changes

migration added

4bf0d39

chamilad reviewed May 29, 2017

View reviewed changes

resources/views/frontend/needs/add.blade.php Outdated

</div>

Copy link

Contributor

chamilad May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many blank lines.

chamilad reviewed May 29, 2017

View reviewed changes

chamilad suggested changes May 29, 2017

View reviewed changes

chamilad mentioned this pull request May 30, 2017

Location sharing ability #14

Open

real time addreess to google map mapping

e9a0883

chamilad reviewed May 30, 2017

View reviewed changes

Merge branch 'dev' into dev

7a39ead

heimdallrj added the DONE label Jun 1, 2017

danishka mentioned this pull request Jun 5, 2017

Expose location of requester to guest user #182

Open

1 task

danishka added Feature PRIORITY labels Jun 5, 2017

danishka added this to the v0.4 milestone Jun 5, 2017

gayanhewa reviewed Jun 5, 2017

View reviewed changes

gayanhewa mentioned this pull request Jun 5, 2017

Geolocation integration forked from PR #48 #184

Merged

naveenmadhawa added a commit that referenced this pull request Jun 6, 2017

Merge pull request #184 from gayanhewa/dulak_dev

334b0d3

Geolocation integration forked from PR #48

dulajsan added 3 commits June 7, 2017 23:50

conflict fix

fec7461

i18n support for error messages

ea92391

modified i18n support for errors

bc1520d

dulajsan commented Jun 8, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

need person's location add using google maps #48

need person's location add using google maps #48

dulajsan commented May 28, 2017

gayanhewa May 29, 2017

gayanhewa left a comment

chamilad May 29, 2017

dulajsan May 29, 2017

chamilad May 29, 2017

chamilad May 29, 2017

dulajsan May 29, 2017

chamilad May 29, 2017

dulajsan May 29, 2017

danishka May 30, 2017

chamilad May 30, 2017

chamilad left a comment

dulajsan commented May 30, 2017

chamilad May 30, 2017

dulajsan May 30, 2017

ishanthilina May 30, 2017 •

edited

Loading

chamilad commented May 30, 2017

dulajsan commented May 30, 2017

danishka commented May 31, 2017

danishka commented Jun 5, 2017

gayanhewa Jun 5, 2017

gayanhewa Jun 5, 2017

dulajsan Jun 8, 2017

dulajsan commented Jun 8, 2017

danishka commented Jun 14, 2017

dulajsan commented Jun 15, 2017

need person's location add using google maps #48

Are you sure you want to change the base?

need person's location add using google maps #48

Conversation

dulajsan commented May 28, 2017

Choose a reason for hiding this comment

gayanhewa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chamilad left a comment

Choose a reason for hiding this comment

dulajsan commented May 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishanthilina May 30, 2017 • edited Loading

Choose a reason for hiding this comment

chamilad commented May 30, 2017

dulajsan commented May 30, 2017

danishka commented May 31, 2017

danishka commented Jun 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dulajsan commented Jun 8, 2017

danishka commented Jun 14, 2017

dulajsan commented Jun 15, 2017

ishanthilina May 30, 2017 •

edited

Loading