Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 - Support Laravel ^11, upgrade to Intervention Image v3 #26

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

reliq
Copy link
Member

@reliq reliq commented Mar 30, 2024

Major changes incl.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 51.64835% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 46.16%. Comparing base (1262221) to head (defe803).

Files Patch % Lines
src/ServiceProvider.php 0.00% 28 Missing ⚠️
src/Service/ConfigProvider.php 0.00% 7 Missing ⚠️
src/Service/ImageManager.php 0.00% 5 Missing ⚠️
src/Demand/Thumbnail.php 33.33% 2 Missing ⚠️
src/Service/ImageDispenser.php 96.77% 1 Missing ⚠️
src/Service/ImageUploader.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #26      +/-   ##
============================================
- Coverage     51.19%   46.16%   -5.03%     
- Complexity      137      138       +1     
============================================
  Files            15       16       +1     
  Lines           504      496       -8     
============================================
- Hits            258      229      -29     
- Misses          246      267      +21     
Flag Coverage Δ
unittests 46.16% <51.64%> (-5.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reliq reliq changed the title wip: v5 - Support Laravel ^11, upgrade to Intervention Image v3 v5 - Support Laravel ^11, upgrade to Intervention Image v3 May 23, 2024
@reliq reliq merged commit d73d0f4 into main May 23, 2024
5 of 9 checks passed
@reliq reliq deleted the next branch May 23, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant