Master #3
Open
Master #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow msg to accept a function to customize output string * use if/else, make errorLogger accept msg function * data is a better parameter name for the template object * update README
move order of middleware definitions
_bodyBlacklist -> _routeBlacklist _bodyWhitelist -> _routeWhitelists
mistake in readme - wrong variable of req
added exceptionToMeta method for filtering returned meta object
fix: limit winston to smaller 3, as winston 3 breaks express-winston.
express-winston _shouldn't_ have any breaking changes as a result.
Currently-supported versions of node (https://github.com/nodejs/Release) are 6, 8, and 10.
Since we're a library (not an app), there seems to be mostly harm from locking down our package versions. The package-lock.json would only apply on a developer's machine, not on CI or for end users, so it seems like it would just mess up users.
Support for Winston 3.x
In their 3.0.0 release, winston deprecated formatting inside transports. This PR adds formats to the options passed into the express-winston logger and errorLogger.
Support winston 3.x transports and formats
Add example for nested whitelists
#66 add response and request whitelist nesting
Fixing 'requestUrl' typo for Google Logging instructions
Enhance "metaField" and add "requestField and "responseField" options
Adding `headerBlacklist` in LoggerOption interface
Add blacklist fields to BaseErrorLoggerOptions interface
Update lodash to 4.17.15 https://www.npmjs.com/advisories/1065
Update lodash to 4.17.15
Add missing exceptionToMeta and skip to TypeScript definition
Update statusLevels to accept Boolean or StatusLevel object
Update to lodash v4.17.19
Update statusLevels type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Link
What type of PR is this?
Description
Give a detailed explanation of what this PR does. Remember to provide context!
Screenshots
What GIF best describes this PR or how it makes you feel?