This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Fix stylelint dummy #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task has been running for quite a while with errors which are only shown in the logs. This should make such errors easier to spot as a part of the pull request status checks.
Running Stylelint on GitHub Actions and locally fails with an error regarding "Could not find "stylelint-config-prettier". Do you need a `configBasedir`?" This adds the missing package.
None of our changes seems to change the current situation of the making reviewdog/action-stylelint fail when stylelint fails. Instead of digging into why we can simplify the current setup by utilizing the direct integration between Stylelint and GitHub through problem matchers. This way we can also drop a dependency on Reviewdog. The stylelint action is the last action in the project using Reviewdog. GitHub reporting requires Stylelint 14.10 so upgrade to that version.
These rules no longer seems to be available so we do not have to reset them either.
This is the result of running yarn run css:format.
These are in preparation for future styling
The plugin is installed and enabled but according to the documentation the rule must also be added. Configure the rule not to require class prefixes as we do not use them.
It is not supported by the plugin.
Blocks and elements must be separated by two underscores.
This should make spotting problems much faster when they occur as a part of the development workflow. Add new scripts using chokidar to watch and run the watching scripts during development.
kasperg
force-pushed
the
fix-stylelint-dummy
branch
from
460362e to
e568d1f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.