Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust final energy carriers for CDR options #1968

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tabeado
Copy link
Contributor

@tabeado tabeado commented Jan 30, 2025

Purpose of this PR

This PR changes the FE carriers that can be used by CDR technologies:

  • dac: feh2s and fegas are fixed to 0 for plausibility reasons.
  • oae_el: feh2s supply is fixed to 0. for plausibility reasons.
  • oae_ng: feh2s supply is added since this is a high-temperature heat process.

We chose to fix some carriers to 0 because removing the carriers proved difficult and the current structure might be needed at a later point when additional process parametrizations might be added.

Type of change

  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I checked the log.txt file of my runs for newly introduced summation, fixing or variable name errors
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@tabeado tabeado requested a review from amerfort January 30, 2025 10:17
@tabeado
Copy link
Contributor Author

tabeado commented Jan 30, 2025

@amerfort re adding feh2s for oae_ng I checked that there is no need to adjust reportFE.
Please let me know if you can think of any other reporting functions that could be affected!

@tabeado tabeado marked this pull request as ready for review January 30, 2025 10:42
@amerfort
Copy link
Contributor

Hi Tabea, thanks for this pragmatic solution.
I want to add that we keep the structure for now as assumptions might be updated within the coming months according to outcomes from the UPTAKE project. Timeline: Until August 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants