Bug fix of accountig of fossil CCS in CDR sector #1970
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR solves this issue in the REMIND code.
Currently, fossil CCS in the CDR sector is not deduced from total fuel combustion (that is calculated in vm_emiTeDetailMkt assuming all fuel is burned and emissions occur for that) in the CDR sector.
This only applies to DAC and OAE and in any case the fossil fuel combustion in the CDR sector is very low. The change does not affect scenario results but is necessary for correct accounting and successful summation checks. CDR emission flows follow the exact same logic as Industry CCS.
This PR should be accompanied by a respective change in the reporting.
I also updated in-code descriptions and improved the name of a variable and a scalar.
Note: As this has to be merged simultaneously with the respective changes in the reporting, this PR is but a draft and I will only merge it, once we decided on the correct accounting of CDR sector emissions in the reporting and I properly tested the changes such that the summation checks succeed.
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededlog.txt
file of my runs for newly introduced summation, fixing or variable name errorsFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):
But be aware, the reporting was not updated in the compare scenarios and due to the variable renaming positive emissions of the CDR sector are not properly calculated.
No changes for scenarios with no dac and oae. ECBudg scenarios did not converge, so a comparison is difficult. In general, residual emissions are slightly lower and carbon prices are also slightly lower after this fix.