Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gms::getLine() instead of re-defining it everywhere #930

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

mikapfl
Copy link
Contributor

@mikapfl mikapfl commented Aug 2, 2022

Purpose of this PR

Instead of defining getLine or variants of it in every script, use the version from gms. This is not a new dependency, we depend on gms anyway in REMIND. See discussion in #929.

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I have performed a self-review of my own code
  • Changes are commented, particularly in hard-to-understand areas
  • I have updated the in-code documentation
  • I have adjusted reporting where it was needed
  • The model compiles and runs successfully (Rscript start.R -q)

@mikapfl mikapfl merged commit 043449b into remindmodel:develop Aug 3, 2022
@mikapfl mikapfl deleted the get-line-gms branch August 3, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants