Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark GROOVY_CLOSURE_CLASS as final and private #2185

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Mark GROOVY_CLOSURE_CLASS as final and private #2185

merged 2 commits into from
Dec 20, 2023

Conversation

vorburger
Copy link
Contributor

No description provided.

remkop
remkop approved these changes Dec 20, 2023
View reviewed changes
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had omitted this because it is a nested class inside the private static class DefaultFactory class. However I have no objection to this change.

@remkop remkop added this to the 4.7.6 milestone Dec 20, 2023
@remkop remkop merged commit abde042 into remkop:main Dec 20, 2023
7 checks passed
@vorburger
Copy link
Contributor Author

I had omitted this because it is a nested class inside the private static class DefaultFactory class. However I have no objection to this change.

FYI Some Checkstyle-like (internal) tool pointed out the missing final, just because of the all uppercase name.

The private may indeed be unnecessary technically, I just added that for consistency while I was at it (the tool did not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop remkop remkop approved these changes

Assignees
No one assigned
Labels
type: enhancement ✨
Projects
None yet
Milestone
4.7.6
Development

Successfully merging this pull request may close these issues.
2 participants
@vorburger @remkop