I hope the last of the saga of line-endings #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkop
approved these changes
Dec 9, 2024
remkop
added a commit
that referenced
this pull request
Dec 9, 2024
|
Apologies for the very long wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in the .gitattributes is crucial. If we leave it only "text", the EOL will be platform dependent. So, I changed all those where the comments say that they should be changed to eol=lf. Then I had to manually add those files that were having some CRLF before and now the git is not marking them as modified any more.
What introduced the CRLF it was the release commit. I hope with this change in .gitattributes, that will not happen any more even if the docs are generated on a windows machine.