renegade_contracts: verifier, darkpool: multiverifier contract #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirillo
force-pushed
the
andrew/multi-verifier-library-contract
branch
from
a91470d
to
7d35e1a
Compare
joeykraut
approved these changes
Sep 1, 2023
akirillo
force-pushed
the
andrew/multi-verifier-library-contract
branch
from
7d35e1a
to
ee3089a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the verifier to manage multiple circuits in a single contract, which bubbles up to the darkpool such that the verifier can be invoked via library calls as opposed to needing to deploy multiple verifier contracts.
All Cairo tests pass, but e2e tests still need to be updated to reflect these changes.
Also, I removed Pedersen generators from contract storage since we consistently use the STARK ECDSA generator everywhere