tests: merkle, darkpool: enable feature flags in e2e tests #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykraut
approved these changes
Sep 3, 2023
| @@ -277,7 +277,11 @@ pub async fn deploy_darkpool( | |||
|
|
|||
| // Deploy darkpool | |||
| debug!("Deploying darkpool contract..."); | |||
| let calldata = vec![account.address()]; | |||
| let calldata = vec
There was a problem hiding this comment.
maybe we should have a constructor for the contract that sets the feature flags to their default values. Want to make absolutely sure we don't have bugs initializing our contract
There was a problem hiding this comment.
I can certainly make a separate function in the deploy scripts that does this. at the contract level, though, there can only be one constructor, and I want it to accept the feature flags as an argument so that we can later redeploy the darkpool with different feature flags successfully (it will be deployed to a different address since it has different constructor calldata). FWIW when we go to mainnet the feature flags will be removed completely.
akirillo
force-pushed
the
andrew/verifier-poseidon-feature-flags
branch
from
d5024f4
to
1d5ba3c
Compare
Base automatically changed from
andrew/verifier-poseidon-feature-flags
to
main
September 4, 2023 21:51
akirillo
force-pushed
the
andrew/feature-flags-e2e-tests
branch
from
1f44fd9
to
c389682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the merkle and darkpool e2e test suites to properly enable the new feature flags.
Tests pass, as do ad-hoc tests asserting that the contracts behave as expected when the flags are disabled.