vspmif-user-module, qosif-user-module: fix header installation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2016 14:25
The do_compile step was copying directly to the sysroot's /usr/include. Because this was a direct copy it was not put into the sstate. The do_install step was installing the same header files into /usr/local/include. Because includedir was not pointed here, they were also not put into the sstate. The issue was then that if you tried to do a build reusing sstate, the header files from vspmif-user-module would not be present, and then dependent recipes like vspmif-tp-user-module. The patch fixes this by removing the direct copy to sysroot, and setting includedir to /usr/local/include. Signed-off-by: Frederico Cadete <[email protected]>
The do_compile step was copying a header file directly into the sysroot. This was not tracked in sstate and can cause problems when builds reuse sstate. Signed-off-by: Frederico Cadete <[email protected]>
fredcadete
changed the title
|
The same issue happened with qosif-user-module |
|
Hi Frederico-san, Thank you for your report. About this problem, investigation is started in our Team. Regards, |
|
Hi Frederico-san, The same problem occurs also in Renesas-Yocto-v2.12.0. The shared include file is installed in /usr/local/include by do_install. STAGING_INCDIR = "${STAGING_DIR_HOST}/${includedir}" W/A sample is the following. --- a/meta-rcar-gen3/recipes-multimedia/vspmif-module/vspmif-user-module.bb
+++ b/meta-rcar-gen3/recipes-multimedia/vspmif-module/vspmif-user-module.bb
@@ -11,6 +11,9 @@ VSPMIF_LIB_DIR = "vspm_if-module/files/vspm_if"
EXTRA_OEMAKE = "ARCH=${TARGET_ARCH}"
+includedir = "/usr/local/include"
+SSTATE_DUPWHITELIST = "${STAGING_INCDIR}"
+
do_compile() {
export VSPM_LEGACY_IF="1"
We will fix this problem in the next release. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recipe is installing headers directly to the sysroot and so they are not tracked in sstate.
This causes sporadic problems in builds that reuse sstate.
To reproduce the proble,:
bitbake vspmif-tp-user-modulemv tmp tmp-old(simulates reusing only sstate)bitbake vspmif-tp-user-module -c cleansstatebitbake vspmif-tp-user-module