feat(node): impl evm and eth #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiintbrisson
requested review from
Supremesource,
steinerkelvin and
devwckd
as code owners
saiintbrisson
force-pushed
the
feat/impl-evm-eth-rpcs
branch
from
fb7a9c1 to
bb83558
Compare
Supremesource
requested changes
Dec 13, 2024
saiintbrisson
force-pushed
the
feat/impl-evm-eth-rpcs
branch
from
bb83558 to
b4ee1ae
Compare
saiintbrisson
force-pushed
the
feat/impl-evm-eth-rpcs
branch
from
b4ee1ae to
b819f79
Compare
Supremesource
approved these changes
Dec 13, 2024
| pub fn create_full<P, A, CT, CIDP>( | ||
| deps: FullDeps<P, A, CT, CIDP>, | ||
| subscription_task_executor: SubscriptionTaskExecutor, | ||
| pubsub_notification_sinks: Arc< |
| fee_history_cache: FeeHistoryCache, | ||
| fee_history_cache_limit: FeeHistoryCacheLimit, | ||
| sync: Arc<SyncingService<Block>>, | ||
| pubsub_notification_sinks: Arc< |
| info: Self::SignedInfo, | ||
| ) -> Option<DispatchResultWithInfo<PostDispatchInfoOf<Self>>> { | ||
| match self { | ||
| call @ RuntimeCall::Ethereum(pallet_ethereum::Call::transact { .. }) => { |
There was a problem hiding this comment.
i would use a if let here and not use the at pattern by matching the reference, but maybe match is better
There was a problem hiding this comment.
i just copied the template tbh, if let would indeed be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ETH and EVM support on both node and runtime. The default precompiles were added. Closes CHAIN-27.