Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist Applications instead of deleting and Remove applications #33

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

steinerkelvin
Copy link
Collaborator

@steinerkelvin steinerkelvin commented Dec 30, 2024

Applications that are resolved (accepted/rejected) or expired will be
persisted in the chain state instead of being deleted to persist the changes
on the ledger and improve the consumption workflow of this data.

Also, now proposals can be used to remove a key from the whitelist.

Pull Request Checklist

Before submitting this PR, please make sure:

  • You have run cargo clippy and addressed any warnings
  • You have added appropriate tests (if applicable)
  • You have updated the documentation (if applicable)
  • You have reviewed your own code
  • You have updated changelog (if applicable)

Related Issues

#34

Copy link

linear bot commented Dec 30, 2024

@steinerkelvin steinerkelvin force-pushed the feat/persist-resolved-applications/chain-37 branch 2 times, most recently from dda71f4 to 60f6295 Compare January 1, 2025 15:46
@steinerkelvin steinerkelvin marked this pull request as ready for review January 1, 2025 15:47
@steinerkelvin steinerkelvin changed the title fix: persist resolved and expired Applications instead of deleting fix: persist Applications instead of deleting and Remove applications Jan 1, 2025
@steinerkelvin steinerkelvin force-pushed the feat/persist-resolved-applications/chain-37 branch from 60f6295 to 4bbc50e Compare January 1, 2025 16:11
@devwckd devwckd force-pushed the feat/persist-resolved-applications/chain-37 branch from 9903d30 to 49362c9 Compare January 3, 2025 01:47
@steinerkelvin steinerkelvin force-pushed the feat/persist-resolved-applications/chain-37 branch from 49362c9 to e252fff Compare January 3, 2025 14:13
steinerkelvin

This comment was marked as outdated.

@steinerkelvin steinerkelvin merged commit 428b398 into main Jan 3, 2025
3 checks passed
@saiintbrisson saiintbrisson deleted the feat/persist-resolved-applications/chain-37 branch January 8, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant