Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change application cost #68

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

steinerkelvin
Copy link
Collaborator

  • feat: change application cost
  • feat: adding migration
  • fix: add weight import
  • feat: add storage version
  • chore: add workflow to build runtime
  • chore: update build workflow to include additional tags and branches
  • chore: update build workflow to include runtime/* tags

Pull Request Checklist

Before submitting this PR, please make sure:

  • You have run cargo clippy and addressed any warnings
  • You have added appropriate tests (if applicable)
  • You have updated the documentation (if applicable)
  • You have reviewed your own code
  • You have updated changelog (if applicable)

Description

Updates the default and migrate value for the Agent Application cost parameter.

Copy link
Contributor

@DaviPtrs DaviPtrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, lgtm

Comment on lines -8 to -10
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why take this out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It seems it was either you, or someone(me) fucking a rebase lol

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think we should allow merge instead of squash in some cases. This PR is one of them. I can explain later.

@steinerkelvin steinerkelvin force-pushed the feat/application-cost-migration branch from b04d5d2 to 7ae9162 Compare January 16, 2025 18:34
@steinerkelvin steinerkelvin force-pushed the feat/application-cost-migration branch from 7ae9162 to 6d46035 Compare January 16, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants