Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BTC address selector #3342

Merged
merged 20 commits into from
Dec 2, 2024
Merged

feat: BTC address selector #3342

merged 20 commits into from
Dec 2, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 27, 2024

Description

  • Re-adds extension wallet multi-address
  • Refactors account interface to have a namespace and conditionally incorporate available account types for other networks
  • Adds BTC specific multi-address handling with a tabs component.

WIP:

  • Using selected address type on BTC calls
  • Refine ui styles

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Showcase

image

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: a84fdca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 4:48pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview Dec 2, 2024 4:48pm
appkit-laboratory-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 4:48pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 4:48pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 4:48pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 4:48pm

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 403.14% 5424 / 24409
🔵 Statements 403.14% 5424 / 24409
🔵 Functions 417.3% 414 / 1487
🔵 Branches 561.0500000000001% 831 / 1828
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 0% 0% 0% 0% 1
packages/appkit/src/client.ts 51.66% 72.88% 72.35% 51.66% 190-191, 234-235, 238-239, 254-257, 260-263, 266-267, 296-307, 310-319, 415, 419, 426, 464-467, 473-480, 483, 571-583, 602-605, 612-613, 621-622, 637-638, 641-642, 645-646, 649-650, 659-669, 675-682, 722-725, 734-763, 765-813, 815-819, 841-846, 848-856, 858-867, 869-889, 891-898, 900-911, 913-926, 928-931, 933-936, 938-941, 943-946, 948-955, 960-1021, 1024-1043, 1051-1052, 1060-1061, 1065-1165, 1168-1180, 1186-1189, 1193-1207, 1217, 1223-1238, 1242-1244, 1248-1263, 1268-1278, 1281-1359, 1362-1382, 1409, 1426, 1455-1461, 1463-1474, 1476-1483, 1497-1498, 1508-1524, 1539-1543, 1558, 1572, 1574-1575, 1620, 1622-1623, 1629-1640, 1647-1648, 1658, 1660, 1741, 1758-1762
packages/appkit/src/adapters/ChainAdapterBlueprint.ts 22.34% 66.66% 18.18% 22.34% 57-58, 66-69, 84-85, 92-101, 108-117, 124-156, 159-160, 169-174, 183-187, 196-200
packages/appkit/src/universal-adapter/client.ts 30.96% 100% 15% 30.96% 29-38, 47-65, 68-69, 72-77, 80-113, 122-125, 128-132, 135-138, 141-144, 147-150, 153-154, 157-158, 161-162, 165-166, 169-170, 173-180, 195-200
packages/core/src/controllers/AccountController.ts 45.1% 92.3% 40% 45.1% 69-76, 79-100, 103-104, 107-108, 111-114, 159-160, 171-172, 175-176, 179-182, 185-188, 191-195, 205-211, 214-220, 223-229, 232-261
packages/core/src/controllers/ChainController.ts 74.8% 67.79% 69.69% 74.8% 72-75, 78-82, 85-102, 107-108, 145-146, 188-198, 203-204, 211, 229-230, 234-242, 274-277, 285-286, 289-290, 299-300, 305-306, 322-323, 328-329, 341-342, 375-383, 386-387, 390-391, 422-429, 441-442, 461-464, 487-488
packages/core/src/utils/CoreHelperUtil.ts 40.43% 71.42% 34.28% 40.43% 11-19, 22-23, 26-29, 32-35, 38-39, 42-43, 46-47, 50-51, 58-59, 73-85, 88-89, 92-114, 117-130, 133-138, 140-141, 144-149, 155-159, 164-173, 192-208, 223-233, 240-245, 264, 266, 268-269, 279-285, 288-292, 301, 306, 311, 321-322, 330-340, 342-351
packages/core/src/utils/TypeUtil.ts 100% 100% 100% 100%
packages/scaffold-ui/src/partials/w3m-account-default-widget/index.ts 0% 0% 0% 0% 1-376
packages/scaffold-ui/src/views/w3m-profile-view/index.ts 0% 0% 0% 0% 1-173
Generated in workflow #7757 for commit a84fdca by the Vitest Coverage Report Action

@tomiir tomiir marked this pull request as ready for review November 27, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants