Fix handling of --start-period option for HEALTHCHECK #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Any chance of a merge of this? |
sashkab
added a commit
to sashkab/docker-postfix
that referenced
this pull request
Aug 2, 2021
sashkab
added a commit
to sashkab/docker-postfix
that referenced
this pull request
Aug 2, 2021
* enable healthcheck * workaround for bug in linter replicatedhq/dockerfilelint#167
|
@marccampbell – another request for a review and merge when you get a chance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As adressed in #166 is_valid_healthcheck() throws an error when the '--start-period' option is provided.
This is due a broken regexp that doesn't handle the dash in the option name.
This PR fixes this.