Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update data prune query to use 'where not exists' instead of 'not in' #541

Merged
merged 2 commits into from
Jan 23, 2024
Merged

update data prune query to use 'where not exists' instead of 'not in' #541

merged 2 commits into from
Jan 23, 2024

Conversation

laverya
Copy link
Member

@laverya laverya commented Jan 23, 2024

No description provided.

@laverya laverya requested a review from a team as a code owner January 23, 2024 15:47
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024 •
edited
Loading

✅ Deploy Preview for kurlsh-testgrid-staging ready!

Name Link
🔨 Latest commit 1165559
🔍 Latest deploy log https://app.netlify.com/sites/kurlsh-testgrid-staging/deploys/65afdfa60078b3000829fd12
😎 Deploy Preview https://deploy-preview-541--kurlsh-testgrid-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024 •
edited
Loading

✅ Deploy Preview for kurlsh-testgrid ready!

Name Link
🔨 Latest commit 1165559
🔍 Latest deploy log https://app.netlify.com/sites/kurlsh-testgrid/deploys/65afdfa63e398a000757c79e
😎 Deploy Preview https://deploy-preview-541--kurlsh-testgrid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dydx
dydx approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@dydx dydx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly using a little bit of GPT to better understand the differences here. It seems pretty plausible that this would be more efficient on larger query results. I think I feel OK approving this.

@laverya laverya merged commit 41362cd into main Jan 23, 2024
12 checks passed
@laverya laverya deleted the laverya/use-not-exists branch January 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@dydx dydx dydx approved these changes

Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laverya @dydx @ricardomaraschini