Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): add create new action for compatibility testing #71

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Jul 24, 2024

  • add a new action to create a cmx cluster for compatibility testing
  • add helm-extra-repos input
      Example:
      helm-extra-repos: |
        - repo_name: "cnpg"
          url: "https://cloudnative-pg.github.io/charts"
          namespace: "cnpg-system"
          chart_name: "cloudnative-pg"
        - repo_name: "minio-operator"
          url: "https://operator.min.io"
          namespace: "minio-operator"
          chart_name: "operator"

an example to use this action

      - name: Create Compatibility Testing
        id: create-compatibility-testing
        uses: replicated-collab/replicated-actions/prepare-cluster@main
        with:
          app-slug: ${{ secrets.REPLICATED_APP }}
          api-token: ${{ secrets.REPLICATED_API_TOKEN }}
          chart: ${{env.chart_name}}-${{ github.event.inputs.version }}.tgz
          kubernetes-distribution: ${{ matrix.cluster.distribution }}
          kubernetes-version: ${{ matrix.cluster.version }}
          helm-chart-name: ${{env.chart_name}}
          namespace: test-${{env.chart_name}}
          helm-run-preflights: false
          helm-extra-repos: |
            - repo_name: "cnpg"
              url: "https://cloudnative-pg.github.io/charts"
              namespace: "cnpg-system"
              chart_name: "cloudnative-pg"
            - repo_name: "minio-operator"
              url: "https://operator.min.io"
              namespace: "minio-operator"
              chart_name: "operator"

@jdewinne
Copy link
Member

Is this different from the cluster prepare action? Is it the case that the only difference is the helm-extra-repos. If that is needed (not sure), maybe we can improve cluster-prepare?

@DexterYan
Copy link
Member Author

Is this different from the cluster prepare action? Is it the case that the only difference is the helm-extra-repos. If that is needed (not sure), maybe we can improve cluster-prepare?

That's a good idea. Let me add it to cluster-prepare

@DexterYan DexterYan requested a review from jdewinne July 28, 2024 23:14
@DexterYan
Copy link
Member Author

Hey @jdewinne I have updated the PR to keep it in cluster-prepare

@@ -156,6 +169,27 @@ runs:
INPUT_IP-FAMILY: ${{ inputs.ip-family || '' }}
INPUT_KUBECONFIG-PATH: ${{ inputs.kubeconfig-path || '' }}
INPUT_EXPORT-KUBECONFIG: ${{ inputs.export-kubeconfig || false }}
- uses: azure/k8s-set-context@v4
with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also include

if: ${{ inputs.helm-extra-repos != '' }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I have added it

@DexterYan DexterYan requested a review from jdewinne August 4, 2024 21:58
@jdewinne jdewinne merged commit 7118df9 into main Aug 5, 2024
3 checks passed
@jdewinne jdewinne deleted the dx/sc-105610/add-cmx-testing branch August 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants