Pass process.platform down to renderer process #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonkaliski
previously requested changes
Aug 15, 2023
szymonkaliski
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If we ever want to do anything OS-specific on the web side (for example, prompt Linux users to download the latest client), it's necessary to know which platform we're on. While we can potentially infer that from the user agent, I'd rather this be an explicit part of the API for ease of use and consistency (on the off-chance the heuristic we use differs from what Node uses).
What changed
Pass process.platform down to renderer process as a new
platformfield on the globalreplitDesktopobjectTest plan
replitDesktop.platformexists and matches expected value