Add onFocusChanged API #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonkaliski
approved these changes
Sep 7, 2023
Base automatically changed from
@sergeichestakov/focus-fullscreen-api
to
main
September 7, 2023 13:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I think we should expose the native focus/blur events to the web client. While you can get around by setting a listener to the corresponding events in the DOM's document window, this feels more technically correct as there is no guarantee that there is a 1:1 correspondence between the two events. Additionally, this is more resilient to edge cases that may arise around iframes and such.
See Slack thread. Fixes WS-996.
What changed
Add onFocusChanged API
Test plan
Will test in follow up corresponding web branch / PR here: https://github.com/replit/repl-it-web/pull/36047