Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for devtools via env var #139

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Add support for devtools via env var #139

merged 2 commits into from
Oct 19, 2023

Conversation

masad-frost
Copy link
Member

@masad-frost masad-frost commented Oct 19, 2023 •
edited
Loading

Why

I need to debug in prod

What changed

Enable devtools menu while in production via env var

Test plan

  • Add ENABLE_DEVTOOLS=1 in shell
  • Start Replit
  • See toggle devtools under view menu

@masad-frost masad-frost requested review from a team, ink404 and sergeichestakov and removed request for a team October 19, 2023 16:47
sergeichestakov
sergeichestakov approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@sergeichestakov sergeichestakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable for internal use, thanks. at some point, would be nice to expose to everyone again in a more deliberate/mindful way

@sergeichestakov sergeichestakov merged commit 5ef2f49 into main Oct 19, 2023
6 checks passed
@sergeichestakov sergeichestakov deleted the fm-devtools branch October 19, 2023 17:15
@masad-frost
Copy link
Member Author

Thanks for merging, I haven't tested it yet just FYI!

@sergeichestakov
Copy link
Contributor

tested it locally - this should work

@sergeichestakov
Copy link
Contributor

will be out in the next deploy, which is likely next week but let me know if you need it earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeichestakov sergeichestakov sergeichestakov approved these changes

@ink404 ink404 Awaiting requested review from ink404 ink404 was automatically assigned from replit/workspace-ux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masad-frost @sergeichestakov