Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desktop app to support new org urls (desktop app update) #170

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

mikewesthad
Copy link
Contributor

@mikewesthad mikewesthad commented Nov 1, 2024

Why

Update the desktop app to support the new org URLs which are in the form /t/orgSlug/orgId/repls/replSlug.

What changed

  • add teamReplUrlRegex for /t/:orgSlug/repls/:replSlug
  • add legacyTeamReplUrlRegex for /t/:orgSlug/:orgId/repls/:replSlug

Test plan

  • create org repl
  • pnpm start:local
  • load the desktop homepage
  • log in
  • load the org repl
  • should work
2024-11-01.11-13-45.mp4

Copy link
Contributor

@sergeichestakov sergeichestakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikewesthad mikewesthad changed the title INC-1725: update desktop app to support new org urls (desktop app update) Update desktop app to support new org urls (desktop app update) Nov 1, 2024
@mikewesthad mikewesthad marked this pull request as ready for review November 1, 2024 16:09
Copy link

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex looks reasonable. Other changes too. I don't have a good setup to test this though.

@mikewesthad mikewesthad merged commit 7a59c4d into main Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants