Add showMessageBox API #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WS-677 Add Dialog API
would be useful to allow web to show native dialogs to the user. for example, in the before unload event if fs status is not clean (see WS-302) |
szymonkaliski
approved these changes
Aug 9, 2023
|
yeah good point. I think the original thinking was because we only wanted to support a subset of the available options but I think we can do such gating on the web side and have the native client support them all in theory. fixed in latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
A message box / dialog API would be generally useful any time we want to show or surface a native dialog to prompt the user from the web side. A concrete example of where this would be useful is if we want to replicate the behavior on web where we confirm if the user wants to leave the Repl (in the
beforeunloadhandler) if the fs is still dirty. See this PR for context: #58Fixes WS-677
What changed
Add showMessageBox API
Test plan
Tested on web in a local branch