Added set of all oci bundles #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airportyh
requested review from
masad-frost and
ryantm
and removed request for
a team
airportyh
force-pushed
the
th-all-oci-bundles
branch
from
1ce6f45 to
f8e0372
Compare
ryantm
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The nixmodules_oci.sh script builds an OCI for every historical module (there are ~110 currently). This is very time and disk space consuming. We can check with the docker repository to be able to only build the ones that do not already exist.
What changed
Test plan
nix eval .#all-modules --json |jqnix build .#'all-phony-oci-bundles."nodejs-18:v10-20230914-1095880"'