Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Removing debugpy override #405

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

blast-hardcheese
Copy link
Contributor

Why

Looks like debugpy got bumped upstream to a version whose nixpkgs patches no longer apply to our pinned 1.8.0 version. Looks like #87 had pinned due to issues with Python 3.11, but googling around suggests this is no longer an issue.

What changed

  • Removed debugpy override

Test plan

  • Manual testing, adding breakpoints, etc.

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner October 11, 2024 23:39
@blast-hardcheese blast-hardcheese requested review from airportyh and removed request for a team October 11, 2024 23:39
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the reason we had this, but if the debugger still works we're good.

@blast-hardcheese blast-hardcheese merged commit 0de5118 into main Oct 11, 2024
1 check passed
@blast-hardcheese blast-hardcheese deleted the dstewart/unpin-debugpy branch October 11, 2024 23:52
blast-hardcheese added a commit that referenced this pull request Oct 12, 2024
This reverts commit 0de5118, reversing
changes made to 42fcc88.
@blast-hardcheese blast-hardcheese mentioned this pull request Oct 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants