Poetry install performance enhancement for low-resource environments #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airportyh
force-pushed
the
th-test-modern-install
branch
from
f42038e
to
b0de042
Compare
airportyh
force-pushed
the
th-test-modern-install
branch
from
69e085a
to
707a144
Compare
added 3 commits
December 7, 2023 22:23
airportyh
changed the title
lhchavez
reviewed
Dec 8, 2023
lhchavez
approved these changes
Dec 8, 2023
Comment on lines
+874
to
+875
| download_file_with_curl(url, str(archive)) | ||
| return archive |
There was a problem hiding this comment.
Suggested change
| download_file_with_curl(url, str(archive)) | |
| return archive | |
| try: | |
| download_file_with_curl(url, str(archive)) | |
| return archive | |
| except: | |
| # If we failed to download with curl, give it another try with the local implementation | |
| logging.exception('failed to download archive with curl. trying again') |
Co-authored-by: lhchavez <[email protected]>
…etry into th-test-modern-install
lhchavez
reviewed
Dec 11, 2023
|
|
||
| url = str(link) | ||
| if os.getenv("POETRY_DOWNLOAD_WITH_CURL") == "1" and url.startswith("https://files.pythonhosted.org/"): | ||
| if self.supports_fancy_output(): |
Comment on lines
+874
to
+875
| download_file_with_curl(url, str(archive)) | ||
| return archive |
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
poetry install is slow for large libraries especially for free accounts. This PR should cut install time by ~50% on average.
Context:
Changes
.pythonlibs(with pip use the--useroption andPYTHONUSERBASEto do this), we made a change to wheel_installer.py that routes file writes to the userbase and usersite directories. This as flagged behindPOETRY_USE_USER_SITE.POETRY_DOWNLOAD_WITH_CURLand it is only activated for URLs startinghttps://files.pythonhosted.org/, because otherwise it could be a private package repo that requires authentication.The plan is to turn on
POETRY_DOWNLOAD_WITH_CURLandPOETRY_USE_USER_SITEfor all repls and turn offPOETRY_INSTALLER_PARALLELfor free accounts (running install jobs in parallel hurts repls with only 1 cpu) via a wrapper script for poetry.Testing