Better fire-and-forget WS closure #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhchavez
force-pushed
the
lh-no-more-fire-and-forget
branch
from
402134e
to
077fba9
Compare
This introduces more problems than what it solves, since now if the application wants to exit, it may orphan this and cause a lot of logspam. This change now closes the websocket in the background task manager so that it is not orphaned upon process exit.
lhchavez
force-pushed
the
lh-no-more-fire-and-forget
branch
from
077fba9
to
980e4cc
Compare
lhchavez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This introduces more problems than what it solves, since now if the application wants to exit, it may orphan this and cause a lot of logspam.
What changed
This change now closes the websocket synchronously to avoid leaking tasks upon exit.
Test plan
Maybe fewer warnings about cancelling pending tasks?