chore: add more eslint (closes #1) (#258)

## Why

<!-- Describe what you are trying to accomplish with this pull request
-->

- consistent style good

## What changed

- add `@stylistic`

<!-- Describe the changes you made in this pull request or pointers for
the reviewer -->

## Versioning

- [ ] Breaking protocol change
- [ ] Breaking ts/js API change

<!-- Kind reminder to add tests and updated documentation if needed -->

.eslintrc.cjs

@@ -15,7 +15,7 @@ module.exports = {
     sourceType: 'module',
     project: ['./tsconfig.json'],
   },
-  plugins: ['@typescript-eslint'],
+  plugins: ['@typescript-eslint', '@stylistic/js', '@stylistic/ts'],
   rules: {
     'linebreak-style': ['error', 'unix'],
     '@typescript-eslint/no-confusing-void-expression': [
@@ -44,6 +44,21 @@ module.exports = {
         allowNumber: true,
       },
     ],
+    '@stylistic/ts/lines-between-class-members': [
+      'error',
+      'always',
+      { exceptAfterSingleLine: true },
+    ],
+    '@stylistic/js/no-multiple-empty-lines': ['error', { max: 1 }],
+    '@stylistic/ts/padding-line-between-statements': [
+      'error',
+      { blankLine: 'always', prev: '*', next: 'return' },
+      {
+        blankLine: 'always',
+        prev: '*',
+        next: ['enum', 'interface', 'type'],
+      },
+    ],
   },
   ignorePatterns: ['dist/**/*'],
 };

__tests__/bandwidth.bench.ts

@@ -41,6 +41,7 @@ describe('bandwidth', async () => {
         const msg = dummyPayloadSmall();
         const id = sendClosure(msg);
         await waitForMessage(serverTransport, (msg) => msg.id === id);
+
         return;
       },
       { time: BENCH_DURATION },

__tests__/cancellation.test.ts

@@ -51,6 +51,7 @@ describe.each(testMatrix(['ws', 'naive']))(
       const setup = await transport.setup({ client: opts, server: opts });
       getClientTransport = setup.getClientTransport;
       getServerTransport = setup.getServerTransport;
+
       return async () => {
         await postTestCleanup();
         await setup.cleanup();
@@ -336,6 +337,7 @@ describe.each(testMatrix())(
       const setup = await transport.setup({ client: opts, server: opts });
       getClientTransport = setup.getClientTransport;
       getServerTransport = setup.getServerTransport;
+
       return async () => {
         await postTestCleanup();
         await setup.cleanup();
@@ -591,6 +593,7 @@ describe.each(testMatrix())(
       const setup = await transport.setup({ client: opts, server: opts });
       getClientTransport = setup.getClientTransport;
       getServerTransport = setup.getServerTransport;
+
       return async () => {
         await postTestCleanup();
         await setup.cleanup();

__tests__/cleanup.test.ts

@@ -45,6 +45,7 @@ describe.each(testMatrix())(
       const setup = await transport.setup({ client: opts, server: opts });
       getClientTransport = setup.getClientTransport;
       getServerTransport = setup.getServerTransport;
+
       return async () => {
         await postTestCleanup();
         await setup.cleanup();
@@ -487,6 +488,7 @@ describe('request finishing triggers signal onabort', async () => {
     const setup = await transport.setup({ client: opts, server: opts });
     getClientTransport = setup.getClientTransport;
     getServerTransport = setup.getServerTransport;
+
     return async () => {
       await postTestCleanup();
       await setup.cleanup();

__tests__/context.test.ts

@@ -26,6 +26,7 @@ describe('should handle incompatabilities', async () => {
     });
     getClientTransport = setup.getClientTransport;
     getServerTransport = setup.getServerTransport;
+
     return async () => {
       await postTestCleanup();
       await setup.cleanup();

__tests__/disconnects.test.ts

@@ -37,6 +37,7 @@ describe.each(testMatrix())(
       const setup = await transport.setup({ client: opts, server: opts });
       getClientTransport = setup.getClientTransport;
       getServerTransport = setup.getServerTransport;
+
       return async () => {
         await postTestCleanup();
         await setup.cleanup();

__tests__/e2e.test.ts

@@ -52,6 +52,7 @@ describe.each(testMatrix())(
       const setup = await transport.setup({ client: opts, server: opts });
       getClientTransport = setup.getClientTransport;
       getServerTransport = setup.getServerTransport;
+
       return async () => {
         await postTestCleanup();
         await setup.cleanup();

__tests__/fixtures/cleanup.ts

@@ -160,6 +160,7 @@ export async function testFinishesCleanly({
 
 export const createPostTestCleanups = () => {
   const cleanupFns: Array<() => Promise<void>> = [];
+
   return {
     addPostTestCleanup: (fn: () => Promise<void>) => {
       cleanupFns.push(fn);

__tests__/fixtures/observable.ts

@@ -37,6 +37,7 @@ export class Observable<T> {
   observe(listener: (val: T) => void) {
     this.listeners.add(listener);
     listener(this.get());
+
     return () => this.listeners.delete(listener);
   }
 

__tests__/fixtures/services.ts

@@ -20,6 +20,7 @@ const testServiceProcedures = TestServiceScaffold.procedures({
     responseData: Type.Object({ result: Type.Number() }),
     async handler({ ctx, reqInit: { n } }) {
       ctx.state.count += n;
+
       return Ok({ result: ctx.state.count });
     },
   }),
@@ -29,6 +30,7 @@ const testServiceProcedures = TestServiceScaffold.procedures({
     responseData: Type.Array(Type.Number()),
     async handler({ ctx, reqInit: { n } }) {
       ctx.state.count += n;
+
       return Ok([ctx.state.count]);
     },
   }),
@@ -133,6 +135,7 @@ export const OrderingServiceSchema = ServiceSchema.define(
       responseData: Type.Object({ n: Type.Number() }),
       async handler({ ctx, reqInit: { n } }) {
         ctx.state.msgs.push(n);
+
         return Ok({ n });
       },
     }),
@@ -153,6 +156,7 @@ export const BinaryFileServiceSchema = ServiceSchema.define({
     responseData: Type.Object({ contents: Type.Uint8Array() }),
     async handler({ reqInit: { file } }) {
       const bytes: Uint8Array = Buffer.from(`contents for file ${file}`);
+
       return Ok({ contents: bytes });
     },
   }),
@@ -236,6 +240,7 @@ export const SubscribableServiceSchema = ServiceSchema.define(
       responseData: Type.Object({ result: Type.Number() }),
       async handler({ ctx, reqInit: { n } }) {
         ctx.state.count.set((prev) => prev + n);
+
         return Ok({ result: ctx.state.count.get() });
       },
     }),
@@ -278,6 +283,7 @@ export const UploadableServiceSchema = ServiceSchema.define({
       for await (const req of reqReadable) {
         result += unwrapOrThrow(req).n;
       }
+
       return Ok({ result: `${reqInit.prefix} ${result}` });
     },
   }),

__tests__/fixtures/transports.ts

@@ -58,6 +58,7 @@ export const transports: Array<TransportMatrixEntry> = [
       const transports: Array<
         WebSocketClientTransport | WebSocketServerTransport
       > = [];
+
       return {
         simulatePhantomDisconnect() {
           for (const transport of transports) {
@@ -87,6 +88,7 @@ export const transports: Array<TransportMatrixEntry> = [
           }, 'debug');
 
           transports.push(clientTransport);
+
           return clientTransport;
         },
         getServerTransport(handshakeOptions) {
@@ -110,6 +112,7 @@ export const transports: Array<TransportMatrixEntry> = [
           }
 
           transports.push(serverTransport);
+
           return serverTransport as ServerTransport<Connection>;
         },
         async restartServer() {

__tests__/invalid-request.test.ts

@@ -33,6 +33,7 @@ describe('cancels invalid request', () => {
     const setup = await transport.setup({ client: opts, server: opts });
     getClientTransport = setup.getClientTransport;
     getServerTransport = setup.getServerTransport;
+
     return async () => {
       await postTestCleanup();
       await setup.cleanup();

__tests__/negative.test.ts

@@ -110,6 +110,7 @@ describe('should handle incompatabilities', async () => {
     const clientTransport = new WebSocketClientTransport(
       () => {
         connectCalls++;
+
         return Promise.resolve(createLocalWebSocketClient(port));
       },
       'client',

codec/json.ts

@@ -9,6 +9,7 @@ function uint8ArrayToBase64(uint8Array: Uint8Array) {
   uint8Array.forEach((byte) => {
     binary += String.fromCharCode(byte);
   });
+
   return btoa(binary);
 }
 
@@ -19,6 +20,7 @@ function base64ToUint8Array(base64: string) {
   for (let i = 0; i < binaryString.length; i++) {
     uint8Array[i] = binaryString.charCodeAt(i);
   }
+
   return uint8Array;
 }
 
@@ -59,6 +61,7 @@ export const NaiveJsonCodec: Codec = {
       ) as unknown;
 
       if (typeof parsed === 'object') return parsed;
+
       return null;
     } catch {
       return null;

logging/log.ts

@@ -29,6 +29,7 @@ const cleanedLogFn = (log: LogFn) => {
     // skip cloning object if metadata has no transportMessage
     if (!metadata?.transportMessage) {
       log(msg, metadata);
+
       return;
     }