more comments, address nits

replit · Oct 17, 2023 · 8182607 · 8182607
1 parent 550e438
commit 8182607
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/transport/ws.ts b/transport/ws.ts
@@ -77,17 +77,21 @@ export class WebSocketTransport extends Transport {
       // send outstanding
       for (const id of this.sendQueue) {
         const msg = this.sendBuffer.get(id);
-        if (msg) {
-          this.ws.send(this.codec.toStringBuf(msg));
+        if (!msg) {
+          return Promise.reject(
+            'tried to resend a message we received an ack for',
+          );
         }
+
+        this.ws.send(this.codec.toStringBuf(msg));
       }
     }
   }
 
   send(msg: OpaqueTransportMessage): MessageId {
     const id = msg.id;
     if (this.destroyed) {
-      return id;
+      throw new Error('ws is destroyed, cant send');
     }
 
     this.sendBuffer.set(id, msg);