feat: buffer codecs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
requested review from
a team,
siliconjungle and
lhchavez
and removed request for
a team
lhchavez
approved these changes
Nov 30, 2023
Comment on lines
+7
to
+23
| function uint8ArrayToBase64(uint8Array: Uint8Array) { | ||
| let binary = ''; | ||
| uint8Array.forEach((byte) => { | ||
| binary += String.fromCharCode(byte); | ||
| }); | ||
| return btoa(binary); | ||
| } | ||
|
|
||
| // Convert base64 to Uint8Array | ||
| function base64ToUint8Array(base64: string) { | ||
| const binaryString = atob(base64); | ||
| const uint8Array = new Uint8Array(binaryString.length); | ||
| for (let i = 0; i < binaryString.length; i++) { | ||
| uint8Array[i] = binaryString.charCodeAt(i); | ||
| } | ||
| return uint8Array; | ||
| } |
There was a problem hiding this comment.
lol this feels extremely inefficient. but it seems like it's what all the internet answer say to do so 🤷.
There was a problem hiding this comment.
good thing we're moving away from json :)
* basic binary codec impl * make e2es run for all codecs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Previously, our codecs only encoded/decoded to/from strings. Both websocket and stdio support using raw binary so let's use that instead of string encoding everything
This opens the door to more efficient binary encodings (and also allows us to use
Type.Uint8Array()in our services!