Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 Patches #257

Merged
merged 10 commits into from
Aug 20, 2024
Merged

v2 Patches #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d0cf2c8
patches checkpoint
jackyzha0 Aug 16, 2024
d551daa
fix rest of the tests
jackyzha0 Aug 19, 2024
f10d335
fix up the rest of the tests
jackyzha0 Aug 19, 2024
bf3dc0a
deflake more things
jackyzha0 Aug 19, 2024
3296099
export flattenErrorType
jackyzha0 Aug 19, 2024
09fc993
fix exports
jackyzha0 Aug 19, 2024
6ecde29
address review comments
jackyzha0 Aug 20, 2024
6f4b50f
better stream cleanup without attaching a million listeners
jackyzha0 Aug 20, 2024
27c3b9e
minor tweaks
jackyzha0 Aug 20, 2024
5cda4d1
bump pkg
jackyzha0 Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PROTOCOL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ The handshake request payload schema is the following:
```ts
type HandshakeRequest = {
type: 'HANDSHAKE_REQ';
protocolVersion: string;
protocolVersion: 'v0' | 'v1' | 'v1.1' | 'v2.0';
sessionId: string;
expectedSessionState: {
nextExpectedSeq: number;
Expand Down
5 changes: 3 additions & 2 deletions __tests__/bandwidth.bench.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { afterAll, assert, bench, describe } from 'vitest';
import { waitForMessage } from '../util/testHelpers';
import { getClientSendFn, waitForMessage } from '../util/testHelpers';
import { TestServiceSchema } from './fixtures/services';
import { createServer } from '../router/server';
import { createClient } from '../router/client';
Expand Down Expand Up @@ -34,11 +34,12 @@ describe('bandwidth', async () => {
serverTransport.clientId,
);

const sendClosure = getClientSendFn(clientTransport, serverTransport);
bench(
`${name} -- raw transport send and recv`,
async () => {
const msg = dummyPayloadSmall();
const id = clientTransport.send(serverTransport.clientId, msg);
const id = sendClosure(msg);
await waitForMessage(serverTransport, (msg) => msg.id === id);
return;
},
Expand Down
Loading
Loading