Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence dts #259

Merged
merged 1 commit into from
Aug 20, 2024
Merged

silence dts #259

merged 1 commit into from
Aug 20, 2024

Conversation

jackyzha0
Copy link
Member

Why

Export "ClientTransport" of module "transport/client.ts" was reexported through module "transport/index.ts" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
Either change the import in "util/testHelpers.ts" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.
Export "ServerTransport" of module "transport/server.ts" was reexported through module "transport/index.ts" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
Either change the import in "util/testHelpers.ts" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.
Export "ClientTransport" of module "transport/client.ts" was reexported through module "transport/index.ts" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
Either change the import in "util/testHelpers.ts" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.
Export "ServerTransport" of module "transport/server.ts" was reexported through module "transport/index.ts" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
Either change the import in "util/testHelpers.ts" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.

What changed

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 requested a review from a team as a code owner August 20, 2024 22:30
@jackyzha0 jackyzha0 requested review from masad-frost and removed request for a team August 20, 2024 22:30
Copy link
Member

@masad-frost masad-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had many more instances of circular imports last I checked, I had a branch that deals with them, quite outdated at this point, but we can revisit later

@jackyzha0 jackyzha0 merged commit dc44581 into main Aug 20, 2024
4 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/import-fix branch August 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants