Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export stream helpers #26

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Export stream helpers #26

merged 1 commit into from
Dec 9, 2023

Conversation

bradymadden97
Copy link
Contributor

I think I want to use these in a stream handler I'm building:

  • Only on stream open do I want to set up some listeners
  • Only on stream close do I want to remove those listeners

This should make it easier than like manually checking ctrl flags

This can just get included in whatever the next release is, it's not urgent.

@jackyzha0
Copy link
Member

Discussed in slack but this type of logic should be handle by waiting on the input stream to end in the handler. This is probably useful down the line so we can merge it but let's not rely on using it

@bradymadden97 bradymadden97 merged commit dedc494 into main Dec 9, 2023
4 checks passed
@bradymadden97 bradymadden97 deleted the export-stream-helpers branch December 9, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants