Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log uncaught errors in handlers #264

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

jackyzha0
Copy link
Member

@jackyzha0 jackyzha0 commented Aug 31, 2024

Why

having o11y into why procedures died unexpectedly is good, we used to have this but lost it in the migration

What changed

re-log errors in procs

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 requested a review from a team as a code owner August 31, 2024 00:23
@jackyzha0 jackyzha0 requested review from bradymadden97 and removed request for a team August 31, 2024 00:23
@jackyzha0 jackyzha0 changed the title log uncaught log uncaught errors in handlers Aug 31, 2024
router/server.ts Show resolved Hide resolved
@jackyzha0 jackyzha0 merged commit 458c827 into main Aug 31, 2024
4 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/log-uncaught-errors branch August 31, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants