Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a special logging tag to uncaught handler exceptions #266

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

masad-frost
Copy link
Member

Why

We want to pipe uncaught errors in handlers to Sentry, we think it's ok to do that via the logger as opposed to having a special error callback.

What changed

  • Add tag uncaught-handler-error
  • Include originalException in extras (for proper stack traces)
  • Change extras in logs from unknown to an optional Record<string, unknown> (we're using it that way anyway, just makes it easier to handle)

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@masad-frost masad-frost requested a review from a team as a code owner September 3, 2024 22:55
@masad-frost masad-frost requested review from Monkatraz and removed request for a team September 3, 2024 22:55
transport/impls/ws/connection.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Monkatraz Monkatraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

transport/impls/ws/connection.ts Outdated Show resolved Hide resolved
@masad-frost masad-frost merged commit 4f610d4 into main Sep 3, 2024
4 checks passed
@masad-frost masad-frost deleted the fm-uncaught-err branch September 3, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants