Add a special logging tag to uncaught handler exceptions #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to pipe uncaught errors in handlers to Sentry, we think it's ok to do that via the logger as opposed to having a special error callback.
What changed
uncaught-handler-error
originalException
inextras
(for proper stack traces)extras
in logs fromunknown
to an optionalRecord<string, unknown>
(we're using it that way anyway, just makes it easier to handle)Versioning