add tests for handlers cleanly exiting #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masad-frost
reviewed
Sep 5, 2024
router/server.ts
Outdated
| @@ -595,6 +598,8 @@ class RiverServer<Services extends AnyServiceSchemaMap> | |||
| reqReadable, | |||
| resWritable, | |||
| }); | |||
|
|
|||
| resWritable.close(); | |||
jackyzha0
commented
Sep 5, 2024
| } else if (procedure.type === 'rpc' || procedure.type === 'subscription') { | ||
| // Though things can work just fine if they eventually follow up with a stream | ||
| // control message with a close bit set, it's an unusual client implementation! | ||
| this.log?.warn('sent an init without a stream close', loggingMetadata); |
There was a problem hiding this comment.
this was noise and didnt tell us anything
router/server.ts
Outdated
| @@ -647,6 +654,7 @@ class RiverServer<Services extends AnyServiceSchemaMap> | |||
| } | |||
|
|
|||
| resWritable.write(responsePayload); | |||
| resWritable.close(); | |||
router/server.ts
Outdated
| if (!newStream.endedSignal.aborted) { | ||
| // if the stream was immediately aborted, don't bother setting it up | ||
| this.streams.set(streamId, newStream); | ||
| } |
There was a problem hiding this comment.
handle cases where we exited from the stream before we set here
masad-frost
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What changed
Versioning