feat: Complete all RPC kinds #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhchavez
force-pushed
the
lh-rpc-supremacy
branch
3 times, most recently
from
196c170 to
ae995ec
Compare
jackyzha0
reviewed
Dec 11, 2023
lhchavez
force-pushed
the
lh-rpc-supremacy
branch
from
ae995ec to
7cfd2ab
Compare
lhchavez
force-pushed
the
lh-rpc-supremacy
branch
from
7cfd2ab to
9b23912
Compare
jackyzha0
reviewed
Dec 12, 2023
lhchavez
force-pushed
the
lh-rpc-supremacy
branch
from
9b23912 to
dce9a30
Compare
|
oh no! i think my previous review comment got lost but:
|
jackyzha0
approved these changes
Dec 12, 2023
lhchavez
force-pushed
the
lh-rpc-supremacy
branch
from
dce9a30 to
321e20c
Compare
We have three of the four gRPC RPC kinds (rpc, stream, subscription). This change adds the final RPC kind: upload (client-stream, single message response). It also adds the option of adding an `init` type to an RPC, where we can send a message of another schema before the main stream, which is a very common pattern used in filesystem (i.e. open file for writing, where the first message is the path and the other messages are the chunks) and collaboration (i.e. first message is the channel name and the rest of the bidirectional messages are the actual stream).
lhchavez
force-pushed
the
lh-rpc-supremacy
branch
from
321e20c to
9f7b068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have three of the four gRPC RPC kinds (rpc, stream, subscription).
This change adds the final RPC kind: upload (client-stream, single
message response). It also adds the option of adding an
inittypeto an RPC, where we can send a message of another schema before the main
stream, which is a very common pattern used in filesystem (i.e. open
file for writing, where the first message is the path and the other
messages are the chunks) and collaboration (i.e. first message is the
channel name and the rest of the bidirectional messages are the actual
stream).