Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WS-2007] feat: connection cleanup handlers #35

Merged
merged 15 commits into from
Dec 15, 2023
Merged

[WS-2007] feat: connection cleanup handlers #35

merged 15 commits into from
Dec 15, 2023

Conversation

jackyzha0
Copy link
Member

@jackyzha0 jackyzha0 commented Dec 14, 2023 •
edited
Loading

  • client should cleanup streams when the connection to the server is killed
  • server should cleanup streams for a client when they disconnect

proc types

  • rpc
  • streams
  • subscription
  • upload

@jackyzha0 jackyzha0 force-pushed the jackyzha0/connection-cleanup branch from 42b5b9e to 52319da Compare December 15, 2023 01:27
@jackyzha0 jackyzha0 changed the title connection cleanup handlers feat:connection cleanup handlers Dec 15, 2023
@jackyzha0 jackyzha0 changed the title feat:connection cleanup handlers feat: connection cleanup handlers Dec 15, 2023
@jackyzha0 jackyzha0 marked this pull request as ready for review December 15, 2023 06:12
@jackyzha0 jackyzha0 changed the title feat: connection cleanup handlers [WS-2007] feat: connection cleanup handlers Dec 15, 2023
@linear Linear
Copy link

linear bot commented Dec 15, 2023

WS-2007 Client/server should appropriately cleanup on unclean disconnect

Let's set a grace period so even if the client/server doesn't leave gracefully, we still cleanup streams and notify the other side

@jackyzha0 jackyzha0 requested a review from moudy December 15, 2023 17:04
moudy
moudy approved these changes Dec 15, 2023
View reviewed changes
Copy link

@moudy moudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jackyzha0
[WS-2011] Typecheck router service definitions (#36)
1835e72 
* type safety in service def building

* [WS-2010] ergonomics: `Transport<T>` -> `T` (#37)
@jackyzha0 jackyzha0 merged commit babbeb8 into main Dec 15, 2023
4 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/connection-cleanup branch December 15, 2023 18:45
@jackyzha0 jackyzha0 restored the jackyzha0/connection-cleanup branch December 15, 2023 18:47
@jackyzha0 jackyzha0 mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moudy moudy moudy approved these changes

@masad-frost masad-frost Awaiting requested review from masad-frost

@bradymadden97 bradymadden97 Awaiting requested review from bradymadden97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyzha0 @moudy