Add injected isomorphic environment #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh hold on there are tests I need to change |
jackyzha0
reviewed
Sep 26, 2023
router/server.ts
Outdated
Comment on lines
34
to
38
| const context: ProcedureContext<object> = { | ||
| environment, | ||
| state: service.state, | ||
| }; | ||
|
|
There was a problem hiding this comment.
isn't this a ServiceContext? would also be good to have a mapping of service -> ServiceContext so that we avoid constructing it on each request
environment/types.ts
Outdated
Comment on lines
2
to
3
| log: (...args: unknown[]) => void; | ||
| error: (...args: unknown[]) => void; |
There was a problem hiding this comment.
can we add a comment here about declaration merging and then add a test that adds something to the environment?
|
not sure how to do the declaration merging test without affecting the exported type |
|
okay, this should be good to go |
jackyzha0
approved these changes
Sep 27, 2023
|
comments addressed after discussion in-person the day before :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that when you create a server, you need to provide an environment to the server. The server will then pass this environment to all procedures that are called. Environments are always the same shape.